How to do a pull request

Client SDKs iOS SDK 📱⌚️💻
#1

I have an issue and was told “Great, do a pull request”. Fine. I fork the project, change the code (just a few lines), then in MacOS “Terminal” attempt to do a commit, which fails:

$ git commit -m “Add SecureEncoder support to PFFileObject” .
error: ‘Vendor/xctoolchain’ does not have a commit checked out
fatal: updating files failed

Is there any documentation on how one should make a pull request on this project?

PS: I asked this already as an issue on the project itself, it was closed and I was told to enter it here.

#2

I can’t delete this, so adding what I did to finally get a PR submitted:

  • you need an open “issue” so do that first if its not already there
  • cloned the repository
  • created a branch
  • edited the appropriate files
  • committed the two files directly (ie not by using “git commit -m “…” .”, but by using the two file paths instead of “.”)
  • used a commit message of “feat: …” (you can find the approved prefixes somewhere)
  • using the GitHub web interface to create a new PR by referencing my fork/branch
  • enter all requested info in the PR description.
  • insure there are no warnings
  • submit